Encrypt totp secrets

This commit is contained in:
Melody Becker 2025-03-31 23:23:25 +02:00
parent c59b0c8340
commit 0fa8f4f7be
No known key found for this signature in database
2 changed files with 35 additions and 3 deletions

View file

@ -10,5 +10,18 @@ var (
ErrInvalidCombination = errors.New("invalid account and token combination") ErrInvalidCombination = errors.New("invalid account and token combination")
ErrProcessTimeout = errors.New("authentication process timed out") ErrProcessTimeout = errors.New("authentication process timed out")
// A user may not login, for whatever reason // A user may not login, for whatever reason
ErrCantLogin = errors.New("user can't login") ErrCantLogin = errors.New("user can't login")
ErrDecryptionFailure = errors.New("failed to decrypt content")
) )
type CombinedError struct {
Err1, Err2 error
}
func (c *CombinedError) Is(e error) bool {
return errors.Is(e, c.Err1) || errors.Is(e, c.Err2)
}
func (c *CombinedError) Error() string {
return c.Err1.Error() + " + " + c.Err2.Error()
}

View file

@ -27,7 +27,7 @@ func (a *Authenticator) PerformTotpLogin(
if err != nil { if err != nil {
return LoginNextFailure, "", other.Error("auth", "failed to find account", err) return LoginNextFailure, "", other.Error("auth", "failed to find account", err)
} }
secrets := sliceutils.Map( encryptedSecrets := sliceutils.Map(
sliceutils.Filter(acc.AuthMethods, func(t models.UserAuthMethod) bool { sliceutils.Filter(acc.AuthMethods, func(t models.UserAuthMethod) bool {
return t.AuthMethod == models.AuthMethodGAuth return t.AuthMethod == models.AuthMethodGAuth
}), }),
@ -35,6 +35,18 @@ func (a *Authenticator) PerformTotpLogin(
return string(t.Token) return string(t.Token)
}, },
) )
secrets := []string{}
for _, key := range encryptedSecrets {
decrypted, err := Decrypt([]byte(config.GlobalConfig.Storage.EncryptionKey), []byte(key))
if err != nil {
return 0, "", other.Error(
"auth",
"failed to decrypt secret",
&CombinedError{ErrDecryptionFailure, err},
)
}
secrets = append(secrets, string(decrypted))
}
found := false found := false
for _, secret := range secrets { for _, secret := range secrets {
if totp.Validate(totpToken, secret) { if totp.Validate(totpToken, secret) {
@ -91,10 +103,17 @@ func (a *Authenticator) StartTotpRegistration(
return nil, err return nil, err
} }
secret := key.Secret() secret := key.Secret()
encryptedSecret, err := Encrypt(
[]byte(config.GlobalConfig.Storage.EncryptionKey),
[]byte(secret),
)
if err != nil {
return nil, other.Error("auth", "failed to encrypt secret", err)
}
authToken := models.UserAuthMethod{ authToken := models.UserAuthMethod{
UserId: acc.ID, UserId: acc.ID,
User: *acc, User: *acc,
Token: []byte(secret), Token: encryptedSecret,
AuthMethod: models.AuthMethodGAuth, AuthMethod: models.AuthMethodGAuth,
Name: tokenName + totpUnverifiedSuffix, Name: tokenName + totpUnverifiedSuffix,
} }