Good progress on styling post-registration form

frontend-reactive/app/components/auth/post-registration-form.hbs

@@ -1,47 +1,63 @@
 <div class="registration-form">
   <h1 class="registration-form-username">username: {{this.args.username}}</h1>
-  <div class="registration-form-displayname-wrapper">
-    <label>
-      Displayname
-      <Input
-        @type="text"
-        @value={{this.displayname}}
-        placeholder="Displayname"
-      />
-    </label>
+  <div class="registration-form-name-mail-wrapper">
+    <div class="registration-form-displayname-wrapper">
+      <label>
+        Displayname
+        <Input
+          @type="text"
+          @value={{this.displayname}}
+          placeholder="Displayname"
+        />
+      </label>
+    </div>
+    <Util::MailEntry
+      @wrapper-classes="registration-form-mail-wrapper"
+      @input-classes="registration-form-mail-input"
+      @data={{this.mail}}
+    />
   </div>
-  <Util::MailEntry @data={{this.mail}}/>
   <div class="registration-form-description-wrapper">
-    <label>
+    <label for="registration-description">
       Description
-      <Input
-        @type="text"
-        @value={{this.description}}
-        placeholder="Account description"
-      />
     </label>
+    <Textarea
+      id="registration-description"
+      @value={{this.description}}
+      placeholder="Account description"
+    />
   </div>
-  <div class="registration-form-gender-wrapper">
-    <p class="registration-form-gender-info">Add your preferred pronouns</p>
+  <fieldset class="registration-form-gender-wrapper">
+    <legend class="registration-form-gender-info">Add your preferred pronouns</legend>
     <Util::StringArray
       @list={{this.gender}}
       @onNewElement={{this.genderAddedHandler}}
       @onDeleteElement={{this.genderRemovedHandler}}
+      @wrapper-classes=""
+      @element-wrapper-classes=""
+      @element-classes=""
+      @remove-element-classes=""
+      @add-element-classes=""
     />
-  </div>
-  <div class="register-form-being-wrapper">
-    <p class="registration-form-being-info">Select the type of being you are. Multiselect is possible</p>
-    <Util::Multiselect @elements={{this.beingTypes}} />
-  </div>
-  <div class="register-form-default-post-mode-wrapper">
-    <p class="registration-form-default-post-mode-info">Select the default mode for your posts</p>
+  </fieldset>
+  <fieldset class="register-form-being-wrapper">
+    <legend class="registration-form-being-info">Select the type of being you are. Multiselect is possible</legend>
+    <Util::Multiselect
+      @elements={{this.beingTypes}}
+      @wrapper-class=""
+      @label-class=""
+      @input-classes=""
+    />
+  </fieldset>
+  <fieldset class="register-form-default-post-mode-wrapper">
+    <legend class="registration-form-default-post-mode-info">Select the default mode for your posts</legend>
     <Util::OneOfArray
       @elements={{array "Public" "Local" "Followers" "Direct"}}
       @selected={{this.defaultpostmode}}
       @name="default-post-mode"
       @required={{true}}
     />
-  </div>
+  </fieldset>
   <div class="register-form-follow-approval-wrapper">
     <label>
       Require approval for follow requests
@@ -58,8 +74,9 @@
       <Input @type="checkbox" name="Indexable" @checked={{this.indexable}} />
     </label>
   </div>
-  <div class="register-form-custom-fields-wrapper">
+  <fieldset class="register-form-custom-fields-wrapper">
+    <legend>Custom fields</legend>
     <Util::MapEdit @list={{this.customProperties}} />
-  </div>
-  {{! TODO: Icon, Background, Banner }}
+  </fieldset>
+  {{! TODO: Icon, Background, Banner, Bluesky toggle }}
 </div>

frontend-reactive/app/components/auth/post-registration-form.ts

@@ -1,29 +1,29 @@
-import { action } from '@ember/object'
-import Component from '@glimmer/component'
-import { tracked } from '@glimmer/tracking'
-import isValidMail from 'frontend-reactive/helpers/is-valid-mail'
+import { action } from '@ember/object';
+import Component from '@glimmer/component';
+import { tracked } from '@glimmer/tracking';
+import isValidMail from 'frontend-reactive/helpers/is-valid-mail';
 
 export interface AuthPostRegistrationFormSignature {
   // The arguments accepted by the component
   Args: {
-    username: string
-  }
+    username: string;
+  };
   // Any blocks yielded by the component
   Blocks: {
-    default: []
-  }
+    default: [];
+  };
   // The element to which `...attributes` is applied in the component template
-  Element: null
+  Element: null;
 }
 
 export default class AuthPostRegistrationForm extends Component<AuthPostRegistrationFormSignature> {
-  @tracked displayname: string = this.args.username
-  @tracked description: string = ''
-  @tracked gender: Array<{ value: string }> = []
+  @tracked displayname: string = this.args.username;
+  @tracked description: string = '';
+  @tracked gender: Array<{ value: string }> = [];
   @tracked beingTypes: Array<{
-    name: string
-    checked: boolean
-    description: string
+    name: string;
+    checked: boolean;
+    description: string;
   }> = [
     {
       name: 'Human',
@@ -55,22 +55,22 @@ export default class AuthPostRegistrationForm extends Component<AuthPostRegistra
       description: 'Doll',
       checked: false,
     },
-  ]
-  @tracked defaultpostmode: string = 'Public'
-  @tracked followapproval: boolean = false
+  ];
+  @tracked defaultpostmode: string = 'Public';
+  @tracked followapproval: boolean = false;
   // Actual custom properties stored in here
-  @tracked customProperties: Array<{ key: string; value: string }> = []
-  @tracked indexable: boolean = true
-  @tracked mail = { mail: '', valid: false }
+  @tracked customProperties: Array<{ key: string; value: string }> = [];
+  @tracked indexable: boolean = true;
+  @tracked mail = { mail: '', valid: false };
 
   genderAddedHandler(newIndex: number) {
-    console.log('gender added')
+    console.log('gender added');
   }
   genderRemovedHandler(removedIndex: number) {
-    console.log('gender removed')
+    console.log('gender removed');
   }
 
   @action test() {
-    console.log(this.mail)
+    console.log(this.mail);
   }
 }

frontend-reactive/app/components/util/mail-entry.hbs

@@ -1,11 +1,18 @@
 <div class="mail-entry {{@wrapper-classes}}">
   <label>
     Email
-    <Input @type="text" @value={{this.args.data.mail}} placeholder="Email address" {{on "change" (fn this.checkMail)}}/>
+    <!--<div class="filling-spacer"/>-->
+    <Input
+      class="mail-input {{if this.mailOk "mail-input-ok" "mail-input-error"}} {{@input-classes}}"
+      @type="text"
+      @value={{this.args.data.mail}}
+      placeholder="Email address"
+      {{on "change" this.checkMail}}
+    />
   </label>
   {{#if this.mailOk}}
-    <p class="mail-ok">O</p>
+    <p class="mail-ok mail-status">&#10004;</p>
   {{else}}
-    <p class="mail-error">X</p>
+    <p class="mail-error mail-status">X</p>
   {{/if}}
 </div>

frontend-reactive/app/components/util/mail-entry.ts

@@ -1,27 +1,27 @@
-import { action } from '@ember/object'
-import { map } from '@ember/object/computed'
-import Component from '@glimmer/component'
-import { tracked } from '@glimmer/tracking'
+import { action } from '@ember/object';
+import { map } from '@ember/object/computed';
+import Component from '@glimmer/component';
+import { tracked } from '@glimmer/tracking';
 
-const re = /.+@\S+\.\S+/
+const re = /.+@\S+\.\S+/;
 
 export interface UtilMailEntrySignature {
   // The arguments accepted by the component
   Args: {
-    data: { mail: string; valid: boolean }
-  }
+    data: { mail: string; valid: boolean };
+  };
   // Any blocks yielded by the component
   Blocks: {
-    default: []
-  }
+    default: [];
+  };
   // The element to which `...attributes` is applied in the component template
-  Element: null
+  Element: null;
 }
 
 export default class UtilMailEntry extends Component<UtilMailEntrySignature> {
-  @tracked mailOk = this.args.data.valid
+  @tracked mailOk = this.args.data.valid;
   @action checkMail() {
-    this.args.data.valid = re.test(this.args.data.mail)
-    this.mailOk = this.args.data.valid
+    this.args.data.valid = re.test(this.args.data.mail);
+    this.mailOk = this.args.data.valid;
   }
 }

frontend-reactive/app/components/util/multiselect.hbs

@@ -5,6 +5,7 @@
       <Input
         @type="checkbox"
         name="{{element.name}}"
+        class="{{@input-classes}}"
         @checked={{element.checked}}
         {{on "change" this.onChange}}
       />

frontend-reactive/app/components/util/string-array.hbs

@@ -2,8 +2,9 @@
   <ul>
     {{#each this.args.list as |element index|}}
       <li>
-        <div class="string-array-element-wrapper">
+        <div class="string-array-element-wrapper {{@element-wrapper-classes}}">
           <Input
+            class="{{@element-classes}}"
             @type="text"
             @value={{element.value}}
           />